Remove sensitive information from debug log#1346
Closed
jpbempel wants to merge 3 commits into
Closed
Conversation
Config.toString() method is dumped when logging in debug the conf. It includes in some case the profile api key when used with env vars. Also proxy password is also dumped. toString method generated by Lombok now excludes both fields
mar-kolya
reviewed
Apr 2, 2020
| */ | ||
| @Slf4j | ||
| @ToString(includeFieldNames = true) | ||
| @ToString(includeFieldNames = true, exclude = {"profilingApiKey", "profilingProxyPassword"}) |
Contributor
There was a problem hiding this comment.
Would have been good to sensor rather than totally hide (i.e. to see that it was provided but we just not showing it vs not provided at all) - but if hard let's add todo to this regards and move on
There was a problem hiding this comment.
Yeah, apparently the Datadog agent logs show the last 5 characters, which is nice
mar-kolya
approved these changes
Apr 2, 2020
Contributor
mar-kolya
left a comment
mar-kolya
left a comment
There was a problem hiding this comment.
Small comment, would be nice to address at least in form of TODO,
otherwise ship it assuming tests pass
Contributor
|
Closing in favour of #1349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.toString() method is dumped when logging in debug the conf.
It includes in some case the profile api key when used with env vars.
Also proxy password is also dumped.
toString method generated by Lombok now excludes both fields